Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCS_MAVLINK: Fix Deprecation of MISSION_REQUEST #28854

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GCS_MAVLINK: Fix Deprecation of MISSION_REQUEST #28854

wants to merge 1 commit into from
+3 −3

Conversation

menschel
Copy link
Contributor

Minor Protocol Issue; Finding during another investigation mavlink/qgroundcontrol#12184

MISSION_REQUEST is deprecated since 2020, replaced with MISSION_REQUEST_INT, but ardupilot still uses it to request mission items from GCS.

https://mavlink.io/en/services/mission.html#uploading_mission
upload

wireshark_mavlink_upload

@menschel menschel force-pushed the pr-fix-deprecated-mavlink-mission-request branch from b86d074 to dd04ec6 Compare December 13, 2024 14:51
@menschel
Copy link
Contributor Author

After applying the patch.

Mavlink_Mission_Upload_with_Fix

I have some internal errors on the test device but I believe that's unrelated. Maybe a little too much flashing between 4.5.7 and master.

@menschel
GCS_MAVLINK: MISSION_REQUEST -> MISSION_REQUEST_INT
1c43fae 
Mission Request Message is deprecated since 2020.
Replaced by Mission Request Int.
@menschel menschel force-pushed the pr-fix-deprecated-mavlink-mission-request branch from dd04ec6 to 1c43fae Compare December 13, 2024 15:39
@peterbarker
Copy link
Contributor

We continue to request MISSION_ITEM so as not to break older ground control stations.

I deal with one which this PR would adversely affect (I'm nudging the author to update....).

Which GCSs have you tested with these changes?

@menschel
Copy link
Contributor Author

menschel commented Dec 14, 2024 •
edited
Loading

I deal with one which this PR would adversely affect (I'm nudging the author to update....).

Please add a link there that marks this PR as duplicate, so it is to be closed along with it.

Which GCSs have you tested with these changes?

I'm hunting some Mavlink issues with QGroundControl and ELRS 900M, very frustrating topic because ELRS 2G4 works perfectly and mLRS 900M also works perfectly.

EDIT:
These also work with the change.

I have to check if this internal error is also present without my patch.

[MAV 001:1] ArduPlane V4.7.0-dev (dd04ec6a) 
[MAV 001:1] ChibiOS: 88b84600 
[MAV 001:1] SpeedyBeeF405WING 003A001E 32335119 31373431 
[MAV 001:1] RCOut: DS600:1-2 PWM:3-10 NeoP:11-12 
[MAV 001:1] PreArm: AHRS: EKF3 not started 
[MAV 001:1] PreArm: AHRS: waiting for home 
[MAV 001:1] PreArm: Internal errors 0x100000 l:1333 flow_of_ct 
[MAV 001:1] rl 
[MAV 001:1] PreArm: waiting for terrain data 
[MAV 001:1] PreArm: Waiting for RC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@menschel @peterbarker